Extract logic out of taglibs - reusability, testability, ...

We should also extract the "snippets" logic that was duplicated in stk (see MGNLSTK-554)

just a note if anybody will start this: be very careful with tag pooling, according to jsp specification you should never change the value of any field set using a tag attribute, since the container is not forced to reset them.

For example if you have two tags in page:
<tag attribute="value"/>
<tag attribute="value"/>

the setAttribute(value) method will be called only the first time, while for the second tag the container expects that the attribute is already set by reusing the previous tag instance. If we extract tags in helper classes me must pay attention to this.

I thought the "new" JSP 2.0 SimpleTag interfaces/classes got rid of all the lifecycle/pooling cruft; one tag in the jsp=one instance of the tag class. Isn't that the case ?

See current draft/concept at http://wiki.magnolia-cms.com/display/DEV/Concept+taglib+cleanup%2C+extraction%2C+rewrite

Integrated in magnolia_main-trunk #1346

Integrated in magnolia_main-trunk #1357
MAGNOLIA-2993 renamed magnolia-authoring-ui to magnolia-templating-ui-components

Integrated in magnolia_main-trunk #1359
MAGNOLIA-2993 renamed package

Integrated in magnolia_main-trunk #1367
MAGNOLIA-3087 / MAGNOLIA-2993 new ui components now registered via Freemarker sharedVariables

Integrated in magnolia_main-trunk #1374
MAGNOLIA-2993 getting there with the FreeMarker directives; JSP Tags still need to be impl

Integrated in magnolia_main-trunk #1402
MAGNOLIA-2993 work-in-progress; extracted factory methods for components and various cleanup

Integrated in magnolia_main-trunk #1405
MAGNOLIA-2993 extracted/renamed utility methods

Integrated in magnolia_main-trunk #1406
MAGNOLIA-2993 added setButtonDelete(String pathToDelete) to BarEdit magnolia-gui component (just simpler to use...) and adapted inline.js#mgnlDeleteNode accordingly

Integrated in magnolia_main-trunk #1407
MAGNOLIA-2993 clarifying comment

Integrated in magnolia_main-trunk #1418
MAGNOLIA-2993 oops; circular dependency...

Integrated in magnolia_main-trunk #1419
MAGNOLIA-2993:

• new component for singleton paragraphs
• support for body for both jsp tags and freemarker directives
• added explicit type params to tags

Integrated in magnolia_main-trunk #1422
MAGNOLIA-2993

Integrated in magnolia_main-trunk #1423
MAGNOLIA-2993 sets buttons to null when disabled

Integrated in magnolia_main-trunk #1425
MAGNOLIA-2993 * added AuthoringUiComponent.postRender()

• editBar is now aware if it being rendering inside a singleton
• separate directive test setup (DirectiveAbstractTestCase) from tests for utility methods of AbstractDirective (AbstractDirectiveTest)

Integrated in magnolia_main-trunk #1426
MAGNOLIA-2993 - reverting r32319 for info.magnolia.cms.taglibs.Include, wasn't meant to be committed

Integrated in magnolia_main-trunk #1432
MAGNOLIA-2993 * now using openutils-testing4web and htmlunit

• some basic tests for EditParagraphBarTag

Integrated in magnolia_main-trunk #1445 * added module descriptor for templating-components

• renamed package from info.magnolia.templatinguicomponents to info.magnolia.module.templatingcomponents
• inverted dependency between templating-components and templating
• renamed magnolia-templating-ui-components to magnolia-module-templating-components
• renamed "target" and "containerNodeName" to content(Name) and container(Name)
• renamed classes, also renamed "main" tag/directive name to "page"
• fixed module descriptor

Integrated in magnolia_main-trunk #1470
MAGNOLIA-2993 i18n for components' labels

• they now have their own resource bundle (messages) instead of (ab)using the admincentral's messages
• paragraph/templates can override labels or use their own, with fallback to the default messages

Integrated in magnolia_main-trunk #1471
MAGNOLIA-2993 copied messages for all languages from admincentral's messages

Integrated in magnolia_main-trunk #1511
MAGNOLIA-2993 don't include magnolia-module-templating-components in the default webapp for now

Integrated in magnolia_main-trunk #1513
MAGNOLIA-2993 bundle for m-m-templating-components; will be in add-ons of the bundles

Integrated in magnolia-bundle_trunk #844
MAGNOLIA-2993 Added magnolia-module-templating-components to add-ons of CE bundle

Integrated in ee_bundle #828
MAGNOLIA-2993 Added magnolia-module-templating-components to add-ons of EE bundle

Status in 4.3

• introduced new magnolia-module-templating-components module, which contains the components themselves (thin wrapper around magnolia-gui components, hiding complexity, providing good defaults) as well as JSP tags and FreeMarker directives
• this new module is currently in the /add-ons folder of the bundles
• it should already be useable as a starting point to integrate with other rendering engines
• i18n

Still to do

• "extract" a few more tags: render ("include"), iterator (sets current content), header links (js and css)
• introduce some form of RenderingContext - holding current model, renderable definition, etc.
• the above and the rendering engine will impact "include" and "iterator"
• refactor components to make it simpler to add extra buttons in main bar, for example (see http://wiki.magnolia-cms.com/display/WIKI/Add+Magnolia+MainBar+functionalities+with+Ajax)
• more simplification: with the introduction of new components such as "singleton", do we still need to be able to be able to disable the delete and move buttons? (we'll probably need a simple "edit" button for page properties to be edited outside the main bar, too)

Fixed in 4.5 when rewriting templating engine.