Magnolia

Request Wrappers hide changes in upstream wrappers

View this issue in another formatViewView
- XML
- Word
- Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.3.7
Fix Version/s: 4.4
Component/s: core
Security Level: Public

Labels:
- servlet
- filter
- wrapper

Description:

Hide

Request wrappers that change the behavior of path info and request parameters need to be modified to expose changes in the wrappers behind them. The problem manifests itself on forward requests.

This affects ServletDispatcherFilter, UnicodeNormalizationFilter, CosMultipartRequestFilter and MultipartRequestFilter.

A suitable test case would be a module with pages that illustrate the problem by returning html containing for instance the word ERROR. An integration test suite can then access these pages and make sure that the word ERROR does not appear.

See http://wiki.magnolia-cms.com/display/DEV/How+servlet+request+wrapping+works for more details.

Show
Request wrappers that change the behavior of path info and request parameters need to be modified to expose changes in the wrappers behind them. The problem manifests itself on forward requests. This affects ServletDispatcherFilter, UnicodeNormalizationFilter, CosMultipartRequestFilter and MultipartRequestFilter. A suitable test case would be a module with pages that illustrate the problem by returning html containing for instance the word ERROR. An integration test suite can then access these pages and make sure that the word ERROR does not appear. See http://wiki.magnolia-cms.com/display/DEV/How+servlet+request+wrapping+works for more details.

Issue Links

causality

This issue is causing:
~~MAGNOLIA-3310~~ UnicodeNormalizationFilter seems to be messing up the virtualUriMappings
~~MAGNOLIA-3264~~ UnicodeNormalizerRequestWrapper.getParameterMap() may return a stale result in case of forwards

relation

This issue is related to:
~~MAGNOLIA-3338~~ Context is not updated on include request

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Hudson CI server added a comment - 09/Nov/10 11:21 AM

Integrated in magnolia_main-4.4-branch #92
~~MAGNOLIA-3337~~ request wrappers

Show

Hudson CI server added a comment - 09/Nov/10 11:21 AM Integrated in

magnolia_main-4.4-branch #92 ~~MAGNOLIA-3337~~ request wrappers

Hide

Permalink

Hudson CI server added a comment - 09/Nov/10 12:22 PM

Integrated in magnolia-bundle_4.4-branch #76
~~MAGNOLIA-3338~~ ~~MAGNOLIA-3337~~ added servlet-sanity-module to integration tests

Show

Hudson CI server added a comment - 09/Nov/10 12:22 PM Integrated in

magnolia-bundle_4.4-branch #76 ~~MAGNOLIA-3338~~ ~~MAGNOLIA-3337~~ added servlet-sanity-module to integration tests

Hide

Permalink

Hudson CI server added a comment - 12/Nov/10 4:48 PM

Integrated in magnolia_main-4.4-branch #117
~~MAGNOLIA-3337~~ testcase no longer invokes filter when bypasses returns false

Show

Hudson CI server added a comment - 12/Nov/10 4:48 PM Integrated in

magnolia_main-4.4-branch #117 ~~MAGNOLIA-3337~~ testcase no longer invokes filter when bypasses returns false

People

Assignee:

Tobias Mattsson

Reporter:

Tobias Mattsson
Votes:

0

Watchers:

0

Dates

Created:

26/Oct/10 11:34 AM

Updated:

01/Dec/10 3:53 PM

Resolved:

09/Nov/10 11:13 AM