Magnolia Diff Module

Add diff support for versioned templates

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Neutral Neutral
  • Resolution: Fixed
  • Affects Version/s: 1.1.3
  • Fix Version/s: 1.1.4
  • Security Level: Public
  • Labels:
    None
  • Release notes required:
    Yes

Issue Links

is depended upon by

New Feature - A new feature of the product, which has yet to be developed. MGNLINTEMPL-26 Add diff support for versioned templates

  • Neutral -
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Improvement - An improvement or enhancement to an existing feature or task. MGNLRES-61 Extending the implementation of the diff tool to the "resources" workspace

  • Neutral -
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hudson CI Server added a comment -

Integrated in ee_magnolia-module-diff #549
MGNLDIFF-25 Add support for diff of single properties.

Show
Hudson CI Server added a comment - Integrated in ee_magnolia-module-diff #549 MGNLDIFF-25 Add support for diff of single properties.
Hide
Permalink
Tobias Mattsson added a comment -

Notes from review:

VersionDiffHtmlServlet

  • the javadoc on the class itself refers to request parameters that are incorrect
  • the javadoc of getSourceUrl says that it will return the url with request parameters for username etc but those are added elsewhere
  • in the text of the diff view there are missing spaces, for instance: "arenot"
  • it might make sense to make the view into a ftl
Show
Tobias Mattsson added a comment - Notes from review: VersionDiffHtmlServlet the javadoc on the class itself refers to request parameters that are incorrect the javadoc of getSourceUrl says that it will return the url with request parameters for username etc but those are added elsewhere in the text of the diff view there are missing spaces, for instance: "arenot" it might make sense to make the view into a ftl
Hide
Permalink
Hudson CI Server added a comment -

Integrated in ee_magnolia-module-diff #550
MGNLDIFF-25 extract template for diff and process it via freemarker

Show
Hudson CI Server added a comment - Integrated in ee_magnolia-module-diff #550 MGNLDIFF-25 extract template for diff and process it via freemarker

People

  • Assignee:
    Jan Haderka
    Reporter:
    Jan Haderka
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
    Date of First Response: