Uploaded image for project: 'A/B Testing'
  1. A/B Testing
  2. ABTEST-539

VariantJcrDataProvider relies on implementation of JcrDataProvider#size

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Neutral
    • None
    • 1.0.1
    • None

    Description

      Steps to reproduce

      1.  Revert https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/2287/overview
      2.  Go to https://nightly.magnolia-cms.com/.magnolia/admincentral#app:abn-testing:detail;/:add
      3. Switch to the Variants tab

      Expected results

      I can still work with the UI

      Actual results

      Infinite loading bar, browser tab not responsive.

      Workaround

      Open new browser tab to unlock the UI, the Variants tab still can't be used though.

      Development notes

      We can see in https://git.magnolia-cms.com/projects/ADDON/repos/ab-testing/browse/magnolia-abtesting-ui/src/main/java/info/magnolia/abtesting/app/dataprovider/VariantJcrDataProvider.java#60 that it overrides #fetch but not #size, relying of the fact the #fetch is called to compute super#size.

      Suggested solution: Implement #size instead of relying on certain super impl.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                rkovarik Roman Kovařík
                AuthorX
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Bug DoR
                    Task DoD