Details
-
Bug
-
Resolution: Unresolved
-
Major
-
None
-
None
-
None
Description
Steps to reproduce
- Do a CSS fix, e.g https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/2211/diff#magnolia-resurface-theme/src/main/resources/VAADIN/themes/resurface/dialogs.scss
- Build UI project
- Make sure the correct version of UI is in the changelog/bundle
- Test the change
Expected results
Without any deep knowledge of dependencies, I expect that
- the build of the changed git project should be enough to apply the changes
- presence of this module in bundle/changelog makes sure the change will be released
Actual results
The changes are not applied unless the admincentral is built/included in the bundle as well.
Workaround
Make sure admincentral version is built / version is updated as well.
Development notes
One solution would be to have both UI and ADMINCENTRAL tickets for every CSS change but that seems to be an overkill and still would require building two different projects.
As theme and admincentral (even though there were thoughts to make the theme pluggable) were always dependent parts, it might make sense to move the resurface-theme UI submodule to the admincentral reactor as well:
- All css issues would be created in ADMINCENTRAL project (this would also solve the reoccurring "who owns the CSS" issue)
- missing admincentral would be catched by automated checks in PR builds/release process
- developers would need only one project to apply the changes
Checklists
Acceptance criteria
Attachments
Issue Links
- mentioned in
-
Page Loading...
1.
|
Implementation |
|
To Do | Unassigned |
2.
|
Review |
|
To Do | Unassigned |
3.
|
Pre-Integration QA |
|
To Do | Unassigned |
4.
|
QA |
|
To Do | Unassigned |