Uploaded image for project: 'Analytics'
  1. Analytics
  2. ANALYTICS-52

DataSuppliers should get client configuration details from DashboardDefinition

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Done
    • Neutral
    • 1.0
    • None
    • None
    • Add-Ons 9
    • 2

    Description

      Currently, our dataSupplier use ChartDefinition#Options differently than it was intended to be. If one gives a look at info.magnolia.analytics.matomo.datasource.MatomoDataSupplierTest it's obvious that chartDefinition.getOptions() are used differently. Normally they are intended to be filters which are applied to the dataSupplier as query or path parameters so far so good but credentials or  link to the server shouldn't be done via Options. Those information should come from DashboardDefinition. DashboardDefinition knows about all the dataSuppliers and chartDefinition knows about which dataSupplier it should get the data from. Hence, Specific dataSupplier should be in the beginning created with correct credentials. 

       

      Acceptance Criteria:

      • Use dashboardDefinition in the DataSuppliers
      • Initialise DataSupplier with correct information which comes from DashboardDefinition (aka credentials, urls etc)
      • Use Options only for specific calls to dataSuppliers e.g. country=VN
      • Adjust tests accordingly

       

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                chuong.doan Chuong Doan Huy
                ilgun Ilgun Ilgun
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0d
                      0d
                      Logged:
                      Time Spent - 6.5h
                      6.5h