Uploaded image for project: 'Blossom'
  1. Blossom
  2. BLOSSOM-207

TabFactory annotation shouldn't set tab label

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Major
    • None
    • 3.0.6
    • None

    Description

      The label of a dialog tab shouldn't be set during creation. Because if the label is missing you can set it with standard i18n property files. This is now not possible with blossom TabFactory annotation.

      DefaultDialogCreator:135

      for (Method tabFactory : classMetaData.getTabFactories()) {
      	TabFactory annotation = tabFactory.getAnnotation(TabFactory.class);
      	TabBuilder tabBuilder = new TabBuilder(annotation.value()).label(annotation.value());
      	dialogBuilder.form().definition().getTabs().add(tabPosition++, tabBuilder.definition());
      
      	ParameterResolver parameters = getTabFactoryParameters(metaData, context, tabBuilder);
      	MethodInvocationUtils.invoke(tabFactory, metaData.getFactoryObject(), parameters);
      }
      

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                tmattsson Tobias Mattsson
                szihlmann Samuel Zihlmann
                Peter Mohn
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD