Uploaded image for project: 'Blossom'
  1. Blossom
  2. BLOSSOM-207

TabFactory annotation shouldn't set tab label

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Major Major
    • None
    • 3.0.6
    • None

      The label of a dialog tab shouldn't be set during creation. Because if the label is missing you can set it with standard i18n property files. This is now not possible with blossom TabFactory annotation.

      DefaultDialogCreator:135

      for (Method tabFactory : classMetaData.getTabFactories()) {
	TabFactory annotation = tabFactory.getAnnotation(TabFactory.class);
	TabBuilder tabBuilder = new TabBuilder(annotation.value()).label(annotation.value());
	dialogBuilder.form().definition().getTabs().add(tabPosition++, tabBuilder.definition());

	ParameterResolver parameters = getTabFactoryParameters(metaData, context, tabBuilder);
	MethodInvocationUtils.invoke(tabFactory, metaData.getFactoryObject(), parameters);
}

        Acceptance criteria

              tmattsson Tobias Mattsson
              szihlmann Samuel Zihlmann
              Peter Mohn
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD