Uploaded image for project: 'Build'
  1. Build
  2. BUILD-1048

Standarize request parsing for magnolia-mgmt's trigger API endpoint

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None
    • None

    Description

      The magnolia-mgmt AP defines a trigger enpoint  to run any of the available fargate tasks defined in ApplicationRunnerTaskExecutor#ACTION.

      This approach works because the samen ACTION enum entry name is used to task definitions in fragate.

      The only drawback of the current approach is that the API lambda controller needs to parse the request body to set the specific environmnet params.

      This can be improved if adhering to the mentioned convention and on top of that we guarantee that for any specific body param its name will be the same as the one defined in Spring config. For example, usgin body.refactoringSpecYaml request param for the
      APP_COMMAND_REFACTOR_REFACTORINGSPECYAML environment config.
       
      If every convention is followed the body can be parsed just convering from camelcase to UPPERCASE_SNAKE_CASE (or even using the propper case in the body request params).
       

       

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                roberto.gomez Roberto Gomez
                Foundation
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoR