Uploaded image for project: 'Build'
  1. Build
  2. BUILD-203

Bypass checkstyle for all generated sources

    XMLWordPrintable

Details

    Description

      We currently bypass checkstyle for clover-generated sources, but we probably want to bypass it for all.
      Leave this open for now because it's debatable. Tools like APT don't always let us hook in to add our license headers and such, but maybe we should actually fix that instead of bypassing.

      If we want it, this patch does the trick:

      iff --git a/build-resources/src/main/resources/magnolia-build-resources/checkstyle-suppressions.xml b/build-resources/src/main/resources/magnolia-build-resources/checkstyle-suppressions.xml
      index 4b92104..faa6bcc 100644
      --- a/build-resources/src/main/resources/magnolia-build-resources/checkstyle-suppressions.xml
      +++ b/build-resources/src/main/resources/magnolia-build-resources/checkstyle-suppressions.xml
      @@ -9,4 +9,7 @@
         <suppress files="src/test/.*" checks="JavadocStyle"/>
         <!-- Excluding Clover-generated sources - See BUILD-57 -->
         <suppress files="target/clover/.*" checks=".*"/>
      +  <!-- Excluding other generated sources -->
      +  <suppress files="target/generated-(test-)?sources/.*" checks=".*"/>
      +
       </suppressions>
      

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              gjoseph Magnolia International
              gjoseph Magnolia International
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: