Uploaded image for project: 'Build'
  1. Build
  2. BUILD-291

Remove ununused com.google.code.findbugs:annotations

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None

    Description

      While I was working on MGNLCE-103 this artifact showed up as being used in resources and main. We made the decision to not add com.google.code.findbugs:annotations to the BOM but to add it to the POM files where Maven suggested it. As this shows up as a 'used undeclared' dependency, it was a warning we needed to take care of, it is more critical than 'unused declared' ones, which we ignore.

      However, as far as I can see, we actually don't use this dependency at all. It is brought in the following way in resource-loader, and somehow Maven's analyzer thinks we are using it:

      [INFO] +- org.reflections:reflections:jar:0.9.9:compile
      [INFO] |  +- org.javassist:javassist:jar:3.18.2-GA:compile
      [INFO] |  \- com.google.code.findbugs:annotations:jar:2.0.1:compile
      

      I don't think we should care because this project is dead. I would therefore suggest the following:

      1. bump reflections to 0.9.11, which no longer uses this dependency
      2. remove the mention of it from main's resource-loader and resource-app
      3. remove it also from the supplemental models?

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                mgeljic Mikaël Geljić
                mmichel Maxime Michel
                Foundation
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoR