Details
-
Task
-
Resolution: Fixed
-
Neutral
-
None
-
None
-
None
-
-
Empty show more show less
-
Empty show more show less
Description
Current impl for creation of new tags requires:
- custom save action
- tag manager
-Moreover current implementation duplicates saving of tags:- fixed by fixed by 7cb13d0116622c12ebd192d3a7924361bd3d4b53 (CONTTAGS-1)
- info.magnolia.contenttags.form.action.SaveDialogWithTagsAction#execute
- info.magnolia.contenttags.manager.TagManager#addTags
- then the mgnl:tags is overwriten by the standard save action (item.apply())--
Proposals:
A] create a custom wrapper which:
- overrides info.magnolia.jcr.wrapper.DelegateNodeWrapper#setProperty(java.lang.String, java.lang.String[]) and creates new tags on the fly
- also overrides session.save() so it saves also the new tags
Benefits: - Handling tags is not bound to UI anymore, but covers also setting tag via a rest endpoint
- We can drop some of the custom actions
B] JCR observer creates new, non existing tags
C] -Drop the tags workspace. Tags don't exist physically but are just words. We can still create a tag app which collects all existing tags. Collect information why was/is the workspace needed.- We need tag names for tag field suggestions
Checklists
Acceptance criteria