Uploaded image for project: 'Content Tags'
  1. Content Tags
  2. CONTTAGS-9

Revisit creation of new tags

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • None
    • None
    • None

    Description

      Current impl for creation of new tags requires:

      • custom save action
      • tag manager

      -Moreover current implementation duplicates saving of tags:- fixed by fixed by 7cb13d0116622c12ebd192d3a7924361bd3d4b53 (CONTTAGS-1)

      1. info.magnolia.contenttags.form.action.SaveDialogWithTagsAction#execute
      2. info.magnolia.contenttags.manager.TagManager#addTags
      3. then the mgnl:tags is overwriten by the standard save action (item.apply())--

      Proposals:

      A] create a custom wrapper which:

      1. overrides info.magnolia.jcr.wrapper.DelegateNodeWrapper#setProperty(java.lang.String, java.lang.String[]) and creates new tags on the fly
      2. also overrides session.save() so it saves also the new tags
        Benefits:
      3. Handling tags is not bound to UI anymore, but covers also setting tag via a rest endpoint
      4. We can drop some of the custom actions

      B] JCR observer creates new, non existing tags
      C] -Drop the tags workspace. Tags don't exist physically but are just words. We can still create a tag app which collects all existing tags. Collect information why was/is the workspace needed.- We need tag names for tag field suggestions

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              rkovarik Roman Kovařík
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoR