Details
-
Bug
-
Resolution: Fixed
-
Neutral
-
None
-
None
-
None
Description
Step to reproduce:
- Open Ecommerce app
- Expand category list of Magento connection, select "Gear" (because there is a product contains a space in SKU) and click "View products" action
- Select "Aviator Sunglasses" product and "View detail"

Then, we got an empty product detail view as below and exception in log:

// Exception ERROR info.magnolia.ecommerce.magento.products.ById 08.07.2019 12:14:21 -- Can not load product [magentoConn/connection/Aviator Sunglasses] from MagentoERROR info.magnolia.ecommerce.magento.products.ById 08.07.2019 12:14:21 -- Can not load product [magentoConn/connection/Aviator Sunglasses] from Magentojava.net.URISyntaxException: Illegal character in path at index 63: http://magento2demo.firebearstudio.com/rest/V1/products/Aviator Sunglasses at java.net.URI$Parser.fail(URI.java:2848) ~[?:1.8.0_201] at java.net.URI$Parser.checkChars(URI.java:3021) ~[?:1.8.0_201] at java.net.URI$Parser.parseHierarchical(URI.java:3105) ~[?:1.8.0_201] at java.net.URI$Parser.parse(URI.java:3053) ~[?:1.8.0_201] at java.net.URI.<init>(URI.java:588) ~[?:1.8.0_201] at org.apache.http.client.utils.URIBuilder.<init>(URIBuilder.java:83) ~[httpclient-4.5.8.jar:4.5.8] at info.magnolia.ecommerce.magento.client.MagentoHttpClient.executeRequest(MagentoHttpClient.java:125) ~[magnolia-ecommerce-magento-connector-1.0-SNAPSHOT.jar:?] at info.magnolia.ecommerce.magento.client.MagentoHttpClient.executeGet(MagentoHttpClient.java:96) ~[magnolia-ecommerce-magento-connector-1.0-SNAPSHOT.jar:?] at info.magnolia.ecommerce.magento.client.MagentoHttpClient.executeGet(MagentoHttpClient.java:89) ~[magnolia-ecommerce-magento-connector-1.0-SNAPSHOT.jar:?] at info.magnolia.ecommerce.magento.products.ById.fetch(ById.java:49) ~[magnolia-ecommerce-magento-connector-1.0-SNAPSHOT.jar:?] at info.magnolia.ecommerce.magento.products.ById.fetch(ById.java:33) ~[magnolia-ecommerce-magento-connector-1.0-SNAPSHOT.jar:?] at info.magnolia.ecommerce.cache.EcommerceCache$ProductById.lambda$fetch$0(EcommerceCache.java:152) ~[magnolia-ecommerce-1.0-SNAPSHOT.jar:?] at com.github.benmanes.caffeine.cache.BoundedLocalCache.lambda$doComputeIfAbsent$14(BoundedLocalCache.java:2039) ~[caffeine-2.6.2.jar:?]
ACs:
- Product detail information shows in subapp
- No error in log
Checklists
Acceptance criteria