Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
3.2.8
-
None
Description
StandardRewirePageLinksHelper performs rewiring based on instance checks of implementations instead of interfaces, which fails for custom field definitions.
void rewriteLinksForField(Node node, EditorPropertyDefinition field, Locale locale, boolean protectFieldAfterRewire) throws Exception { ... } else if (field instanceof CompositeFieldDefinition) { this.handleCompositeField(node, (CompositeFieldDefinition) field, locale, protectFieldAfterRewire); } else if (field instanceof ConfiguredSwitchableFieldDefinition) { this.handleSwitchableField(node, (ConfiguredSwitchableFieldDefinition) field, locale, protectFieldAfterRewire); } }
Using interfaces would allow for custom implementations:
CompositeFieldDefinition -> FormDefinition
ConfiguredSwitchableFieldDefinition -> SwitchableFormDefinition
Checklists
Acceptance criteria
Attachments
Issue Links
- mentioned in
-
Page Loading...