Uploaded image for project: 'Sitedesigner (closed)'
  1. Sitedesigner (closed)
  2. MGNLSD-27

site designer: entering width in % instead of pixels throws NumberFormatException

    XMLWordPrintable

Details

    • Bug
    • Resolution: Outdated
    • Minor
    • 1.2
    • 0.9
    • None

    Description

      If you enter into a width layout field the width as percent (e.g. 80%) instead of pixels (e.g.900) an exception is thrown.

      • exceptions should not be delivered to the end user in such a way that it scares them
      • its probably desirable to allow % for the width

      Action: catch exception and warn user or allow %

      ------------------------

      type Exception report

      message

      description The server encountered an internal error () that prevented it from fulfilling this request.

      exception

      javax.servlet.ServletException: javax.servlet.jsp.JspException: For input string: "20%"
      org.apache.jasper.runtime.PageContextImpl.doHandlePageException(PageContextImpl.java:821)
      org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:758)
      org.apache.jsp.templates.siteDesigner.mainEntry_jsp._jspService(mainEntry_jsp.java:130)
      org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
      javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324)
      org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
      org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
      javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      info.magnolia.module.templating.renderers.JspTemplateRenderer.renderTemplate(JspTemplateRenderer.java:74)
      info.magnolia.cms.filters.MgnlCmsFilter.handle(MgnlCmsFilter.java:163)
      info.magnolia.cms.filters.MgnlCmsFilter.doFilter(MgnlCmsFilter.java:104)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.cache.CacheFilter.doFilter(CacheFilter.java:93)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MgnlInterceptFilter.doFilter(MgnlInterceptFilter.java:128)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MgnlContextFilter.doFilter(MgnlContextFilter.java:45)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.security.SecurityFilter.doFilter(SecurityFilter.java:96)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MultipartRequestFilter.doFilter(MultipartRequestFilter.java:80)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MgnlVirtualUriFilter.doFilter(MgnlVirtualUriFilter.java:83)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.ContentTypeFilter.doFilter(ContentTypeFilter.java:66)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MagnoliaManagedFilter.doFilter(MagnoliaManagedFilter.java:71)

      root cause

      java.lang.NumberFormatException: For input string: "20%"
      java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
      java.lang.Integer.parseInt(Integer.java:456)
      java.lang.Integer.parseInt(Integer.java:497)
      org.apache.jsp.templates.siteDesigner.global.layout_jsp._jspService(layout_jsp.java:135)
      org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
      javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324)
      org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
      org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
      javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      org.apache.taglibs.standard.tag.common.core.ImportSupport.acquireString(ImportSupport.java:296)
      org.apache.taglibs.standard.tag.common.core.ImportSupport.doEndTag(ImportSupport.java:161)
      org.apache.jsp.templates.siteDesigner.global.head_jsp._jspx_meth_c_import_3(head_jsp.java:258)
      org.apache.jsp.templates.siteDesigner.global.head_jsp._jspService(head_jsp.java:88)
      org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
      javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324)
      org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
      org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
      javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      org.apache.taglibs.standard.tag.common.core.ImportSupport.acquireString(ImportSupport.java:296)
      org.apache.taglibs.standard.tag.common.core.ImportSupport.doEndTag(ImportSupport.java:161)
      org.apache.jsp.templates.siteDesigner.mainEntry_jsp._jspx_meth_c_import_0(mainEntry_jsp.java:149)
      org.apache.jsp.templates.siteDesigner.mainEntry_jsp._jspService(mainEntry_jsp.java:84)
      org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
      javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324)
      org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
      org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
      javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      info.magnolia.module.templating.renderers.JspTemplateRenderer.renderTemplate(JspTemplateRenderer.java:74)
      info.magnolia.cms.filters.MgnlCmsFilter.handle(MgnlCmsFilter.java:163)
      info.magnolia.cms.filters.MgnlCmsFilter.doFilter(MgnlCmsFilter.java:104)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.cache.CacheFilter.doFilter(CacheFilter.java:93)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MgnlInterceptFilter.doFilter(MgnlInterceptFilter.java:128)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MgnlContextFilter.doFilter(MgnlContextFilter.java:45)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.security.SecurityFilter.doFilter(SecurityFilter.java:96)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MultipartRequestFilter.doFilter(MultipartRequestFilter.java:80)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MgnlVirtualUriFilter.doFilter(MgnlVirtualUriFilter.java:83)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.ContentTypeFilter.doFilter(ContentTypeFilter.java:66)
      info.magnolia.cms.filters.MagnoliaManagedFilter$CustomFilterChain.doFilter(MagnoliaManagedFilter.java:106)
      info.magnolia.cms.filters.MagnoliaManagedFilter.doFilter(MagnoliaManagedFilter.java:71)

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              tomwespi Tom Wespi
              kraft Boris Kraft
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: