Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-1512

Request charset should be set before any req.getParameter call

    XMLWordPrintable

Details

    • New Feature
    • Resolution: Fixed
    • Major
    • 3.1 M2
    • None
    • core
    • None

    Description

      At the moment, the request charset is set using Aggregator.getExtension(), which in turns uses Context.getAttribute. Since the WebContextImpl implementation of getAttribute calls getParameter in case the attribute does not exist on the request, thus making the setCharacterSet call useless - and preventing parameters to be parsed properly (indeed, the container will parse them on the first call to getParam*() with a default encoding - iso-8859-1 in the case of tomcat)

      We might solve this by making the Aggregator.getExtension method (and associated) just using the context attribute - which have to be set previously, for instance by a new filter that has yet to be created.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                gjoseph Magnolia International
                gjoseph Magnolia International
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: