Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-250

showPreview() is broken

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 2.1 Final
    • 2.0 Final
    • core
    • None
    • any

    Description

      Resource.showPreview(HttpServletRequest) is looking for a request parameter "preview" in order to determine, if a request is showing a preview of a page. As a result, a call to the method always returns "false".

      The method should check for "mgnlPreview" instead, and not just check for its existence, but also its value. The check must be something like:

      (request.getSession().getAttribute("mgnlPreview") != null) &&
      (request.getSession().getAttribute("mgnlPreview").equalsIgnoreCase("true"))

      I have set this to major since I consider it an important method for building controllers.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              fgiust Fabrizio Giustina
              weder Andreas Weder
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD