Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-2517

Cleaner refactoring for previewMode

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Do
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: admininterface, core, gui
    • Labels:
      None

      Description

      While working on MAGNOLIA-2245, previewMode is being moved from info.magnolia.cms.util.Resource to AggregationState.
      Given the InterceptFilter is setting this flag, and uses the session to do so, it seems we could use a cleaner implementation.

      Using the session is somehow still needed, for instance to serve resources / images appropriately.

      One of the things that bother me with the current implementation is that gui components access the aggregation state freely (global state) - this c/should instead be passed to the output methods.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                gjoseph Magnolia International
                Reporter:
                gjoseph Magnolia International
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Date of First Response: