Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-2528

Remove dependency to admincentral messages in MessagesManager

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Do
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: admininterface, core
    • Labels:
      None

      Description

      MessagesManager.DEFAULT_BASENAME currently refers to a file which is in fact in the admincentral module. This a completely soft dependency, so the worse that could happen is that those messages aren't found - however, for isolation, cleanliness and testability, this shouldn't be the case.
      We probably don't even need a default messages at all - or maybe a very limited one with just a couple of messages about Magnolia (version, build and so on? - although these informations are also provided by LicenseFileExtractor)

      Since I'm adding tests for MessagesManager, I'll add a fake resource file in the core/test folders to work around this for now.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pbaerfuss Philipp Bärfuss
              Reporter:
              gjoseph Magnolia International
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Date of First Response: