Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-2621

Extract interface from MessagesManager

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 4.0
    • 4.0
    • core
    • None

    Description

      Hi.
      We need to extends MessagesManager. I see (MAGNOLIA-2273) you've introduces the getInstance() by using FactoryUtils, but the problem is that the resulting object is casted to MessagesManager itself, which is final, no allowing subclassing.
      I attach a patch in which i create a MessagesProvider interface, apply that to MessagesManager and use it for the MessagesManager.getInstance()

      I think that MessagesManager could be improved by allowing, via configuration, to add Messages implementations to be (on startup or on configuration changes) chained in newMessages method.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                fgiust Fabrizio Giustina
                manuelmolaschi Manuel Molaschi
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD