Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-2878

Dialog class and saveHandler is no more used/called

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • 4.3.2
    • 4.1
    • None
    • None

    Description

      On a new module, the class and saveHandler parameter of a Dialog is no more used.

      I have 2 examples (cf. attachements)

      • In the Excel Renderer module that I changed for the compatibility with templating kit (saveHandler)
      • In another module, with the using of the class

      I added tracing in my code:

      public class WSTDownloadLinkListDialog extends ParagraphEditDialog{

      public WSTDownloadLinkListDialog(String name, HttpServletRequest request, HttpServletResponse response, Content configNode)

      { super(name, request, response, configNode); log.info("WSTDownloadLinkListDialog instanciated"); }

      And in Excel Renderer module:

      public class ExcelTransformerSaveHandler extends UUIDSaveHandler {
      protected void processBinary(Content node, String name) throws RepositoryException

      { super.processBinary(node, name); removePreRenderedProperty(name, node); log.info("processBinary"); }

      protected void processString(Content node, String name, int type, int encoding, String[] values, String valueStr) throws PathNotFoundException, RepositoryException, AccessDeniedException {
      super.processString(node, name, type, encoding, values, valueStr);
      final DialogControlImpl control = getControl(name);
      log.info("pprocessString General");
      if (control instanceof UUIDDialogControl)

      { log.info("pprocessString Control"); removePreRenderedProperty(name, node); }

      }

      I can see the dialogs but these classes are never instantiated and the method are never called (constructor for WSTDownloadLinkListDialog ).

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                pbaerfuss Philipp Bärfuss
                bsegaert Benoit Segaert
                Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD