Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-3050

Add missing methods to BinaryNodeData for getting/setting attributes

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Outdated
    • Major
    • None
    • None
    • None
    • None

    Description

      I noticed only recently that BinaryNodeData has methods for setting attributes like:

      setAttribute(String name, String value)
      setAttribute(String name, Calendar value)
      

      but it misses the method for setting Longs or Doubles (I was wondering why the image size is set as a string and not as a long in jcr, this is probably the reason).

      Also for getting attributes it only has:

      public String getAttribute(String name) {
      

      which is already strange since the setter already supports also Calendars.

      What about cleaning it up in order to allow all the available types? we could maybe just add a getNodeData(String name) method similar to the one in Content (making clear that a binary node data can have other node data nested)?

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                dlipp Daniel Lipp
                fgiust Fabrizio Giustina
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD