Details
-
Improvement
-
Resolution: Outdated
-
Minor
-
None
-
2.1 Final, 3.0.2
-
None
-
n/a
Description
HierarchyManager exposes the following mutator methods:
- void setStartPage(Node) [unused!]
- void init(Node)
- void init(Node, AccessManager)
- void setAccessManager(AccessManager)
In all cases where these methods are used, they are used:
a) ONCE only, and
b) on a HierarchyManager instance which is assigned to a local variable in the same method
It would better reflect the manner in which HierarchyManager is used if the fields 'startPage', 'workspace', and 'accessManager' were set only via the constructor, and the mutator methods removed.
Checklists
Acceptance criteria
Attachments
Issue Links
- is related to
-
MAGNOLIA-1442 Review the HierarchyManager interface
-
- Closed
-