Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-316

HierarchyManager can become immutable with respect to most of its fields.

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Outdated
    • Minor
    • None
    • 2.1 Final, 3.0.2
    • core
    • None
    • n/a

    Description

      HierarchyManager exposes the following mutator methods:

      • void setStartPage(Node) [unused!]
      • void init(Node)
      • void init(Node, AccessManager)
      • void setAccessManager(AccessManager)

      In all cases where these methods are used, they are used:

      a) ONCE only, and
      b) on a HierarchyManager instance which is assigned to a local variable in the same method

      It would better reflect the manner in which HierarchyManager is used if the fields 'startPage', 'workspace', and 'accessManager' were set only via the constructor, and the mutator methods removed.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                scharles Sameer Charles
                db@dawnbreaks.net David Bullock
                Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD