Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-3174

Error page not rendered anymore after an exception on a template

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Neutral
    • None
    • 4.3.1
    • rendering, templating
    • None

    Description

      Not sure what has changed, but looks like that after 4.3-m3 response pages in case of errors during the template rendering have been broken.

      Same page, same error: in previous versions the error page is properly served, in 4.3 final/4.3.1 we only get a blank page with a "response already committed" in tomcat logs.

      The flush of the response is done in info.magnolia.module.templating.renderers.AbstractTemplateRenderer.renderTemplate() in a finally block.
      Looks like the flush() was already there but somehow it was not breaking error pages.... after the introduction of the RenderingEngine I have to remove the flush() for making error pages work again.

      Should we move the out.flush() outside the finally block to fix it? Is anybody aware of the reason why it should be there?

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              fgiust Fabrizio Giustina
              fgiust Fabrizio Giustina
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD