Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-324

Using jsp:directive.include for JS Files is Incorrect

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • None
    • None
    • None
    • None
    • Resin 3.0.12. Tomcat might ignore this error and continue gracefully.

    Description

      According to the JSP specification:

      ========================
      JSP.5.2.4 The jsp:directive.include element

      The jsp:directive.include element is used to substitute text and/or
      code at JSP page translation-time. This element can appear anywhere
      within a JSP document. Its syntax is:

      <jsp:directive.include file="relativeURLspec" />

      The interpretation of a jsp:directive.include element is as in Section
      JSP.2.10.3. The XML view of a JSP page does not contain
      jsp:directive.include elements, rather the included file is expanded
      in-place. This is done to simplify validation.
      ========================

      As a result, the JavaScript files are being parsed as XML before being inserted. Since they AREN'T XML files, parsing fails:

      [09:17:07.553] /admintemplates/js/../../admindocroot/js/i18n.js:56: expected `>' at ``;'' (for tag `<args.length>' at line 56). The XML tag syntax is: <tag attr1='value1'>

      The fix, fortunately, is not so difficult. If you really want to use jsp:directive.include, all the included JSP files must be enclosed in CDATA tags.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              pbaerfuss Philipp Bärfuss
              barik Titus Barik
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD