Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-3346

Change Node2BeanTransformerImpl#setProperty for better fail safety

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Do
    • Minor
    • None
    • 4.5
    • core

    Description

      Current implementation can produce misleading logs/exceptions in case you have an error in the adder-method: right now we'll call the setter on any exception of the call of the adder. If there was an exception in the adder, nothing is put out but we try to call the setter with the same params. This will most likely fail and you'll get this in the logs. So logs tell there's been a problem with the setter but actually the adder is the culprit.

      That's why the setter should only be called in case the adder does not exist. In case there is an adder and calling it throws an exception, we should properly output this exception and not try to call the setter at all.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              dlipp Daniel Lipp
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoD