Details
-
Bug
-
Resolution: Won't Do
-
Major
-
None
-
4.4.2
-
None
Description
When I use noEditBars="true" and the Paragraph throws an Exception all paragraphs afterwards get no edit-bar.
I found that the last part that restores the previewMode is not run when an Exception is thrown in this code.
if(noEditBars && !orgShowPreview){
aggregationState.setPreviewMode(true);
}
if (this.path != null) { // TODO
log.warn("You are using the deprecated path attribute
of the include tag. Your jsp will be included for now, but you might
want to update your code to avoid bad surprises in the future.");
pageContext.include(this.path);
} else {
WebContext webContext = MgnlContext.getWebContext();
webContext.setPageContext(pageContext);
webContext.push((HttpServletRequest)pageContext.getRequest(),
(HttpServletResponse)pageContext.getResponse());
try {
renderingEngine.render(content, pageContext.getOut());
} finally{
webContext.pop();
webContext.setPageContext(null);
}
}
if(noEditBars){
aggregationState.setPreviewMode(orgShowPreview);
}
Checklists
Acceptance criteria
Attachments
Issue Links
- is related to
-
MAGNOLIA-3687 RenderingEngine does not restore aggregation state when throwing RenderException
-
- Closed
-