Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-4133

FCKEditor does not handle phonenumber-links properly

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 4.4.7
    • 4.4.5, 4.5.1
    • fckeditor
    • None
    • Linux

    Description

      I am trying to use tel-links (http://www.marketingtechblog.com/hyperlink-phone-number/) in the FCKEditor.
      Magnolia interprets them as internal links and mangles them up.
      It make maintaining a mobile-site a bit of a pain.

      The problem is that tel-links is not detected in the LinkUtil.EXTERNAL_LINK_PATTERN and thus is categorized as an internal link and treated as such.
      Since the problem is occurring in the Loader for the FCKEditor you can still create the link and have it work if you refrain from editing the text afterwards. If you do edit the text however, the link will be corrupted.

      Fix:

      info.magnolia.link.LinkUtil.EXTERNAL_LINK_PATTERN should be changed from:
      Pattern.compile("^(\\w*://|mailto:|javascript:).*");
      

      to this:

      Pattern.compile("^(\\w*://|mailto:|javascript:|tel:).*");
      

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              ejervidalo Espen Jervidalo
              dwijk Daniel Wijk
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD