Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-4870

Move SplitUtil to core ?

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Neutral
    • None
    • None
    • core
    • None
    • Yes
    • Yes

    Description

      Countless times, I wrote utility methods, or tests, to validate a usage of some split method. Typically, we need to split comma-separated value input strings.

      A quick check on Magnolia-core reveals inconsistent and error-prone usage of several different methods: grep -ri split magnolia-core/

      None of these usages really provide a safe output; in some cases we trim the input, but in most cases an input of " a, b,c" will yield different results than "a,b,c", and that is most likely not desired.

      Here's a proposal to move a utility class I wrote for the external-indexer module, along its extensive unit tests. If this goes through, you'll certainly want to check the current usages of StringUtils.split() and String.split() !

      git@git.magnolia-cms.com:forge/external-indexing

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              gjoseph Magnolia International
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD