Details
-
Bug
-
Resolution: Won't Do
-
Neutral
-
None
-
None
-
None
-
-
Yes
-
Empty show more show less
-
Yes
Description
Countless times, I wrote utility methods, or tests, to validate a usage of some split method. Typically, we need to split comma-separated value input strings.
A quick check on Magnolia-core reveals inconsistent and error-prone usage of several different methods: grep -ri split magnolia-core/
None of these usages really provide a safe output; in some cases we trim the input, but in most cases an input of " a, b,c" will yield different results than "a,b,c", and that is most likely not desired.
Here's a proposal to move a utility class I wrote for the external-indexer module, along its extensive unit tests. If this goes through, you'll certainly want to check the current usages of StringUtils.split() and String.split() !
git@git.magnolia-cms.com:forge/external-indexing
- Source: http://git.magnolia-cms.com/gitweb/?p=forge/external-indexing.git;a=blob;f=magnolia-module-external-indexing/src/main/java/info/magnolia/externalindexing/util/SplitUtil.java
- Test: http://git.magnolia-cms.com/gitweb/?p=forge/external-indexing.git;a=blob;f=magnolia-module-external-indexing/src/test/java/info/magnolia/externalindexing/util/SplitUtilTest.java
- Repo: https://git.magnolia-cms.com/git/forge/external-indexing.git
- ./magnolia-module-external-indexing/src/main/java/info/magnolia/externalindexing/util/SplitUtil.java
- ./magnolia-module-external-indexing/src/test/java/info/magnolia/externalindexing/util/SplitUtilTest.java