Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-5006

Add versions for ui artifacts in ce-bundle

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Beta 2
    • Magnolia Release:
      5.0

      Description

      We need to put in the versions of ui artifacts in the parent pom to make sure the right versions are used.

      We don't want a module thats added to bundled-webapp with dependency on ui-framework-beta1-4 to override our intended ui-framework-beta1-7.

      The dependency tree of bundled-webapp is:

      INFO] info.magnolia:magnolia-bundled-webapp:war:5.0-SNAPSHOT
      [INFO] +- info.magnolia:magnolia-empty-webapp:war:5.0-SNAPSHOT:compile
      [INFO] +- info.magnolia:magnolia-empty-webapp:pom:5.0-SNAPSHOT:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-admincentral:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-framework:jar:5.0-beta1-7:compile
      [INFO] |  |  |  +- info.magnolia.ui:magnolia-ui-actionbar:jar:5.0-beta1-7:compile
      [INFO] |  |  |  +- info.magnolia.ui:magnolia-ui-dialog:jar:5.0-beta1-7:compile
      [INFO] |  |  |  \- info.magnolia.ui:magnolia-ui-form:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-workbench:jar:5.0-beta1-7:compile
      [INFO] |  |  |  +- info.magnolia.ui:magnolia-ui-imageprovider:jar:5.0-beta1-7:compile
      [INFO] |  |  |  \- info.magnolia.ui:magnolia-ui-statusbar:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-vaadin-theme:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-mediaeditor:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-vaadin-widgetset:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-vaadin-common-widgets:jar:5.0-beta1-7:compile
      [INFO] |  |  \- info.magnolia.ui:magnolia-ui-widget-editor:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-sample:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-pages:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-config:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-security:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-messages:jar:5.0-beta1-7:compile
      [INFO] +- info.magnolia.app.contacts:magnolia-app-contacts:jar:1.0-beta1-4:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-api:jar:5.0-beta1-7:compile
      [INFO] |  \- info.magnolia.ui:magnolia-ui-contentapp:jar:5.0-beta1-7:compile
      [INFO] |     \- info.magnolia.ui:magnolia-ui-vaadin-integration:jar:5.0-beta1-7:compile
      

      If someone adds a module that defines a dependency on any artifact that is not directly depended upon by empty-webapp it will override. Because those dependencies appear at depth 4 and 5. In the custom module they would be at depth 3. Maven takes the one with the least depth.

      [INFO] info.magnolia:magnolia-bundled-webapp:war:5.0-SNAPSHOT
      [INFO] +- info.magnolia:magnolia-empty-webapp:war:5.0-SNAPSHOT:compile
      [INFO] +- info.magnolia:magnolia-empty-webapp:pom:5.0-SNAPSHOT:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-admincentral:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-framework:jar:5.0-beta1-7:compile
      [INFO] |  |  |  +- info.magnolia.ui:magnolia-ui-actionbar:jar:5.0-beta1-7:compile
      [INFO] |  |  |  \- info.magnolia.ui:magnolia-ui-dialog:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-workbench:jar:5.0-beta1-7:compile
      [INFO] |  |  |  +- info.magnolia.ui:magnolia-ui-imageprovider:jar:5.0-beta1-7:compile
      [INFO] |  |  |  \- info.magnolia.ui:magnolia-ui-statusbar:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-vaadin-theme:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-mediaeditor:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-vaadin-widgetset:jar:5.0-beta1-7:compile
      [INFO] |  |  +- info.magnolia.ui:magnolia-ui-vaadin-common-widgets:jar:5.0-beta1-7:compile
      [INFO] |  |  \- info.magnolia.ui:magnolia-ui-widget-editor:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-sample:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-pages:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-config:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-security:jar:5.0-beta1-7:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-app-messages:jar:5.0-beta1-7:compile
      [INFO] +- info.magnolia.app.contacts:magnolia-app-contacts:jar:1.0-beta1-4:compile
      [INFO] |  +- info.magnolia.ui:magnolia-ui-api:jar:5.0-beta1-7:compile
      [INFO] |  \- info.magnolia.ui:magnolia-ui-contentapp:jar:5.0-beta1-7:compile
      [INFO] |     \- info.magnolia.ui:magnolia-ui-vaadin-integration:jar:5.0-beta1-7:compile
      [INFO] \- custommodule:custommodule:jar:1.0:compile
      [INFO]    \- info.magnolia.ui:magnolia-ui-form:jar:5.0-beta1-1:compile
      

      We have already added some dependencies in empty-webapp and bundled-webapp on the 5.0-stable branch only.
      https://git.magnolia-cms.com/gitweb/?p=ce-bundle.git;a=commit;h=2f12b50be763ddb421cb0fee4b968b2ea77414b1
      https://git.magnolia-cms.com/gitweb/?p=ce-bundle.git;a=commit;h=4c74d0edef2be069b39819ba5d3d5735cbd2f471

        Attachments

          Activity

            People

            Assignee:
            tmattsson Tobias Mattsson
            Reporter:
            tmattsson Tobias Mattsson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: