Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-5167

StoreTest is only passing by accident

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5.10
    • Component/s: cache, testing
    • Labels:
      None
    • Magnolia Release:
      4.5.10

      Description

      StoreTest.testClearCacheWhenExceptionOccurs() is currently setting up the cache directory to be target/cacheTest, but asserts that target/tmp exists and is empty. The tmp dir happens to be created by CacheResponseWrapper.thresholdReached() calling Path.getTempDirectory()

      Suggestion: extract a subclass that gets reused accross the cache test which configures those directories, assert they don't exit in @Before and removes them in @After

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jsimak Jaroslav Simak
              Reporter:
              gjoseph Magnolia International
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: