Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-536

Make it easier to extend

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 2.1 Final
    • 2.1 Final
    • core
    • None
    • all

    Description

      if getHierarchyManager() is private, a lot of redundant code has to be maintained in the subclass.

      Note that the patch format below is different from the previos ones. The patch is directly extracted from my own global patch file. I hope you can apply the patch via command line the usual way. If not, I always can produce a special patch for you. Let me know.

      patch for revision 1437 of tagged version /magnolia2.1 :

      — /home/maem/workspace/Pagnolia2.1/src/originals/magnolia-2.1/src/main/info/magnolia/cms/exchange/simple/SimpleExchangeServlet.java 2005-08-31 11:29:13.000000000 +0200
      +++ /home/maem/workspace/Pagnolia2.1/src/patched/magnolia-2.1/src/main/info/magnolia/cms/exchange/simple/SimpleExchangeServlet.java 2005-08-31 11:31:31.000000000 +0200
      @@ -275,7 +275,7 @@
      }
      }

      • private HierarchyManager getHierarchyManager() throws Exception {
        + protected HierarchyManager getHierarchyManager() throws Exception { return this.hierarchyManager; }

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              pbaerfuss Philipp Bärfuss
              aemi Michael Aemisegger
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoD