Uploaded image for project: 'Magnolia Workflow Module'
  1. Magnolia Workflow Module
  2. MGNLWORKFLOW-212

Workflow CommandWorkItemHandler ignores failed command

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Neutral
    • 5.4
    • 5.2.2
    • None

    Description

      Line 61-65:

       try {
                  commandsManager.executeCommand(commandName, parameters);
              } catch (Exception e) {
                  parameters.put(Context.ATTRIBUTE_EXCEPTION, e);
              }
      

      commandsManager.executeCommand returns a boolean representing a successful execution of the command. This is ignored by the CommandWorkItemHandler and failed commands that do not explicitly throw an Exception are treated as successful.

      Additionally, the throwing of java.lang.Exception in the CommandsManager should possibly be investigated regarding it's necessity.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              ejervidalo Espen Jervidalo
              dean.pullen Dean Pullen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoD