Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-5750

Cargo: replace uses of zipUrlInstaller by artifactInstaller

    XMLWordPrintable

    Details

    • Magnolia Release:
      4.5.25, 5.3.9

      Description

      In the configuration of the cargo plugin, we can
      1) Replace this:

      <zipUrlInstaller>
        <url>http://dist.codehaus.org/jetty/jetty-6.1.22/jetty-6.1.22.zip</url>
        <installDir>${basedir}/tmp/cargo-install</installDir>
      </zipUrlInstaller>
      

      by this:

      <artifactInstaller>
        <groupId>org.mortbay.jetty</groupId>
        <artifactId>jetty</artifactId>
        <classifier>bundle</classifier>
        <version>6.1.26</version>
      </artifactInstaller>
      

      This might require some research to find the correct artifacts, but it seems recent containers have an artifact available.
      If we need to keep the different profiles (our int tests can (in theory) run on different containers), will require introducing a couple of properties or rearranging the configuration to some extent. (perhaps move part of the cargo config in the profiles entirely, which means some could still be using a url)

      2) Replace or remove this: <home>${basedir}/tmp/cargo-home</home>. Defaults to ${project.build.directory}/cargo/configurations/${containerId}, which is just as well.

      Benefits:

      • job really cleans itself entirely, no tmp folder lying around in the workspace (by default, the container is downloaded under target/, so we originally configured cargo this way to avoid re-downloading the container for every build)
      • the container distribution (zip) is cached the local maven repository, so we won't download it every time either.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              gjoseph Magnolia International
              Reporter:
              gjoseph Magnolia International
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: