Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-5872

Add branch name in the "build number" property

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major Major
    • 4.5.22, 5.2.8, 5.3.3
    • None
    • core
    • None

      The "license" file exposes a BuildNumber property, which currently contains a timestamp and git revision nr; it'd be nice if this would also give the branch name. This is possible since BUILD-105. Requires updating parent poms to v29.

      Example patch (am not convinced by the "format", so please come up with better)

      diff --git a/magnolia-core/src/main/resources/info/magnolia/cms/license/license.xml b/magnolia-core/src/main/resources/info/magnolia/cms/license/license.xml
index 1ac8b4e..f38a7d2 100644
--- a/magnolia-core/src/main/resources/info/magnolia/cms/license/license.xml
+++ b/magnolia-core/src/main/resources/info/magnolia/cms/license/license.xml
@@ -20,7 +20,7 @@
     <Meta>
         <VersionNumber>${magnoliaNiceVersion}</VersionNumber>
         <Edition>${magnoliaEdition}</Edition>
-        <BuildNumber>${magnoliaReleaseDate} (rev. ${buildScmRevisionNumber})</BuildNumber>
+        <BuildNumber>${magnoliaReleaseDate} (rev. ${buildScmRevisionNumber} on branch ${buildScmBranch})</BuildNumber>
         <Provider>${pom.organization.name}</Provider>
         <ProviderAddress>
             <![CDATA[

        Acceptance criteria

              dlipp Daniel Lipp
              gjoseph Magnolia International
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoR