Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-5884

Extending node does not inherit things that the extended node inherits from its ancestors

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Neutral
    • None
    • 5.3.2
    • None
    • None

    Description

      This is an esoteric case where extends does not work correctly. To see the effect, do the following:

      1. Lets call dialog /modules/standard-templating-kit/dialogs/pages/home/stkHomeProperties n1
      2. Duplicate it twice into n2 and n3
      3. Delete everything under n2.form and make n2.form extend n1.form
      4. Add an empty content node n2.form.tabs
      5. Delete everything under n3.form.tabs
      6. Make n3.form.tabs extend n2.form.tabs
      7. Use n3 in place of n1 in /modules/standard-templating-kit/templates/pages/stkHome@dialog
      8. Open the demo-project page in Page Editor and edit properties, see that the dialog does not display correctly

      Theoretically, it should display correctly because n2.form extends n1.form, so n2.form.tabs contains everything in n1.form.tabs. Since n3.form.tabs extends n2.form.tabs, it should have everything in n1.form.tabs. Thus n3 should be the same as n1.

      This is a problem that was first noticed in ExtendingNodeWrapper code. Basically, if A extends B, A considers everything that B extends, but not what B might have inherited as a result of one of its ancestors extending something else.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              cheng.hu Cheng Hu
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD