Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-5904

Mycila-Guice dependency: Apply the provided patch to the Mycila version 2.10GA

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Fix
    • Critical
    • None
    • 5.2.7, 5.3.2
    • core

    Description

      Mycila is a java library for Google-Guice. The method following method was noticed to be blocking:

      com.mycila.inject.internal.Reflect#annotatedBy(final Class<? extends Annotation> annotationType)
      

      The method calls "java.lang.reflect.Method#declaredAnnotations()" which is synchronized. The results are not buffered. Mycila is currently used in Version 2.10GA as a dependency of Magnolia 5.3.1 Core

      Work around:
      Creating a patched version of Mycila 2.10GA and changing the calls of „java.lang.reflect.Method#declaredAnnotations()“ to „com.mycila.inject.internal.Reflect#annotatedBy(final Class<? extends Annotation> annotationType)“ by coating it with a cache.

      Stacktrace of the code path can be found here https://github.com/mycila/guice/issues/6

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                dlipp Daniel Lipp
                cringele Christian Ringele
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD