Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-6033

Upgrade info.magnolia.templating.elements.ComponentElement functions to not return null but default values.

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Do
    • Neutral
    • None
    • 5.3.6
    • None
    • None

    Description

      functions resolveMoveable, resolveWritable, resolveDeletable sometimes not returns default value but returns null. f.e. resolveDeletable could be updated to

      private Boolean resolveDeletable(final OperationPermissionDefinition permissions, User user) {
      
              Boolean deletable = this.deletable != null ? this.deletable : componentDefinition != null && componentDefinition.getDeletable() != null ? componentDefinition.getDeletable() : null;
              // try to get the permissions from template availability
              if (permissions != null && !permissions.canDelete(user)) {
                  return false;
              }
      
              if (deletable != null) {
                  return deletable;
              }
      
              // true by default
              return true;
          }

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              efochr Evzen Fochr
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoD