Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-6321

Avoid dependencies to MgnlContext, Content API and others in NodeUtil, NodeTypes, ...

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Critical
    • None
    • None
    • core
    • 21

    Description

      In attempting to split out magnolia-jcr-utils out of magnolia-core, which should be a library of utilities that are as Magnolia-agnostic as possible, the following was highlighted:

      • info.magnolia.jcr.util.NodeUtil has dependencies on MgnlContext, Content (that's the old content api we've been trying to get rid of), PermissionUtil. It also has dependencies on DateUtil and OrderedProperties; while debatable, those could be extracted elsewhere or are probably easier to remove.
      • other classes of the info.magnolia.jcr.util package have these dependencies as well as to e.g info.magnolia.link, which seems completely out of place.
      • info.magnolia.jcr.util.NodeTypes is Magnolia-specific but represents our basic node types, which are relatively neutral. It could probably remain in magnolia-jcr-util, but we might want to either change its package and/or revise the description of the module slightly.

      Patches:
      https://git.magnolia-cms.com/users/ejervidalo/repos/core-split-scripts/browse/patches/0001-MAGNOLIA-6321-remove-dependency-to-Context-Path-and-.patch
      https://git.magnolia-cms.com/users/ejervidalo/repos/core-split-scripts/browse/patches/0002-MAGNOLIA-6321-remove-dependency-to-MgnlContext-from-.patch

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              gjoseph Magnolia International
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Checklists

                  Task DoR