Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-6615

UserManager#getUsersWithGroup(groupName, transitive) is b0rked, never worked

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.3.7, 5.4.5
    • Fix Version/s: 5.3.15, 5.4.6
    • Component/s: security
    • Labels:
    • Release notes required:
      Yes
    • Sprint:
      Saigon 39
    • Story Points:
      8
    • Magnolia Release:
      5.3.15, 5.4.6

      Description

      UserManager#getUsersWithGroup(groupName, transitive) is just b0rked and most likely never worked properly...

      Considering user/group setup from_templating-samples_, as follows:

      • (group) employees
        • (user) eve
        • (user) patrick
        • (group) developers
          • (user) david

      UserManager#getUsersWithGroup("employees", true) doesn't return david (wrong)
      whereas UserManager#getUser("david").getAllGroups() correctly returns developers + employees (correct)

      Concept: Implementing only part https://wiki.magnolia-cms.com/display/DEV/Concept+-+Improvements+in+the+security+package#Concept-Improvementsinthesecuritypackage-1a.super-groupsvs.sub-groups
      Solution: Provide new API to return all sub-groups MgnlGroupManager#getAllSubGroups and use that API to resolve all users transitively-assigned sub-groups correctly

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                oanh.thai Oanh Thai Hoang
                Reporter:
                mgeljic Mikaël Geljić
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Date of First Response:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4d Original Estimate - 4d
                  4d
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 5d 5h
                  5d 5h