Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-6736

Expose Map2Bean conversion errors via DefinitionProvider interface

    Details

    • Type: Story
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 5.4.7
    • Fix Version/s: 5.5
    • Component/s: None
    • Labels:
      None

      Description

      Improve DefinitionProvider#getErrorMessages() API with respect to the fact that M2B now returns more sophisticated Problem objects.

      Collect problems from conversion result produced by M2B (in YamlDefinitionProvider#resolve). Also provide fallback support for the old API.

      At the same time we should adjust the validity criteria of a definition provider: currently DefinitionProviderBuilder.DefinitionProviderImpl#DefinitionProviderImpl() assumes any error message makes provider invalid, but we could encounter also just a warning => I suggest to iterate over the newly introduced problems and check their types searching for the the most severe ones.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                apchelintcev Aleksandr Pchelintcev
                Reporter:
                apchelintcev Aleksandr Pchelintcev
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 1h
                  1h