Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-6835

Migrating node types results in useless log statements – fix or remove

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 5.5
    • None
    • None
    • None
    • Basel 67
    • 1

      info.magnolia.setup.nodetype.AbstractNodeTypeRegistrationTask#registerNodeTypes will produce a log.info when re-registering a node type. Unfortunately underlying objects of the second given parameter – a list of javax.jcr.nodetype.NodeTypeDefinition s – do not have a toString method resulting in:

      [INFO] [talledLocalContainer] 2016-10-20 11:27:27,460 INFO  ia.setup.nodetype.AbstractNodeTypeRegistrationTask: Registering mgnl:activatable and the following depending nodeTypes: [org.apache.jackrabbit.core.nodetype.NodeTypeImpl@19684b13, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@24ee4b6d, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@49f45a4f, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@42d1899c, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@40cfdfef, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@326d0566, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@475f7599, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@793bbecc, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@53310785, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@1cdd45a, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@5ad23f97, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@1a516d39, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@496c5a65, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@540629a5, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@3f140b87, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@76b9daf9, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@64ad3a7, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@5594e83d, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@2e650c6, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@4bd7a2f8, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@7b8b16c0, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@20e0ea71, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@10b0fecb, org.apache.jackrabbit.core.nodetype.NodeTypeImpl@66064e47]

      We should fix this or get rid of the log statement.

      Side note

      Unregistration of node types log properly:

      [INFO] [talledLocalContainer] 2016-10-20 11:27:28,329 INFO  ia.setup.nodetype.AbstractNodeTypeRegistrationTask: Unregistered the following NodeTypes '[mgnl:asset, mgnl:content, mgnl:item, mgnl:role, mgnl:group, mgnl:systemMessage, mgnl:tag, mgnl:persona, mgnl:variants, mgnl:segment, mgnl:contact, mgnl:user, mgnl:rssAggregator, mgnl:page, mgnl:siteMap, mgnl:category, mgnl:variant, mgnl:deleted, mgnl:versionable]'.

        Acceptance criteria

              fgrilli Federico Grilli
              pmundt Philip Mundt
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoR

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 1h
                    1h