-
Bug
-
Resolution: Fixed
-
Neutral
-
5.4
-
None
-
-
Empty show more show less
-
Kromeriz 75
-
3
With the adaption of the rendering module to the new registry API (see MAGNOLIA-6070) and the deprecation of info.magnolia.rendering.renderer.registry.ConfiguredRendererProvider, the configured type of any renderer is not taken into account anymore.
Furthermore getting any renderer by method info.magnolia.rendering.renderer.registry.RendererRegistry#getRenderer(String type) will not return the renderer by its type but rather by configured name = it's node name.
This problem was revealed by problem reporting of node2bean and the definitions app. E.g for renderer jsp from /modules/rendering/renderers/jsp:
Property [type] not found in class [info.magnolia.rendering.renderer.JspRenderer], property is not assigned
Suggested solution (tbd)
"Add property type" to interface info.magnolia.rendering.renderer.Renderer and adjust RendererRegistry to be capable of retrieving renderers by their type.
Notice
Luckily this issue might not be very severe, as it was relatively common to have concurrence in node name and type.
Affected renderers
- site and site-jsp (module: site)
- sitemap (module: google-sitemap)
- textResource, referenceResource and binaryResource (module: resources)
- noscript and plaintext (module: templating)
- jsp and freemarker (module: rendering)
- possibly more