Details
-
Task
-
Resolution: Fixed
-
Neutral
-
5.4, 6.2.24
-
None
-
-
Empty show more show less
-
Empty show more show less
-
Yes
-
Nucleus 24
-
1
Description
Steps to reproduce
- Open https://nightly.magnolia-cms.com/.magnolia/admincentral#app:resources:edit;/travel-demo-marketing-tags/templates/pages/main-marketing-tags.ftl:edit
- Make the FTL produce an error, e.g. put unclosed expression (${nonExistingVariable}) in the body, save.
- Open https://nightly.magnolia-cms.com/.magnolia/admincentral#app:pages-app:detail;/travel:edit
Expected results
A yellow freemarker error is rendered.
Actual results
The freemarker error is not rendered, just logged.
Workaround
Restart the instance.
Development notes
The observed component for freemarkerConfig is not initialized at this point:
public FreemarkerHelper(final FreemarkerConfig freemarkerConfig, TranslationService translationService, MagnoliaConfigurationProperties properties) {
...
cfg.setTemplateExceptionHandler(freemarkerConfig.getTemplateExceptionHandler());
...
As a consequence, freemarker errors are not displayed in the page editor (it's using the default ignore handler).
After restart, FreemarkerConfig is initialized first, then FreemarkerHelper, correctly.
This has probably something to do with initialising the helper for the installation phase when the observed components are not yet initialised.
Checklists
Acceptance criteria
Attachments
Issue Links
- mentioned in
-
Page Loading...
1.
|
Implementation |
|
Completed | Adam Siska | ||||||||
2.
|
Code review |
|
Completed | Sang Ngo Huu |
|
|||||||
3.
|
Preintegration QA |
|
Completed | Sang Ngo Huu |
|
|||||||
4.
|
QA |
|
Completed | Roman Kovařík |
