Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-7114

NPE when setting permissions and roles empty in YAML file

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 5.5.5
    • None
    • None

    Description

      If I export an app to YAML and put to light module folder, it has empty config for permission as bellow:

      'permissions':
        'roles':
      

      It throws NPE and block accessing to admincentral

      Caused by: java.lang.NullPointerException
      	at info.magnolia.cms.security.operations.ConfiguredAccessDefinition.hasAccess(ConfiguredAccessDefinition.java:72)
      	at info.magnolia.ui.api.app.launcherlayout.AppLauncherLayoutManagerImpl.isAppVisibleForUser(AppLauncherLayoutManagerImpl.java:234)
      	at info.magnolia.ui.api.app.launcherlayout.AppLauncherLayoutManagerImpl.getLayoutForUser(AppLauncherLayoutManagerImpl.java:149)
      	at info.magnolia.ui.admincentral.shellapp.applauncher.AppLauncherShellApp.<init>(AppLauncherShellApp.java:103)
      	... 114 more
      

      Investigate:

      Should check null for roles in info.magnolia.cms.security.operations.ConfiguredAccessDefinition#hasAccess

      public boolean hasAccess(User user) {
              Collection<String> userRoles = user.getAllRoles();
      
              if (roles.isEmpty() || userRoles.contains(this.superuserRole) || CollectionUtils.containsAny(userRoles, roles)) {
                  return true;
              }
              return false;
          }
      

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              sang.ngo Sang Ngo Huu
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Checklists

                  Bug DoR
                  Task DoD