Uploaded image for project: 'Magnolia'
  1. Magnolia
  2. MAGNOLIA-985

cleanup of import methods in DataTransporter (and depending classes) as preliminary work for new XSL transformation feature

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Fix
    • Minor
    • 3.0 RC3
    • 3.0 RC3
    • core
    • None

    Description

      Renamed methods, made them more consistent and improved javadoc. This is preliminary work for a new XSL transformation feature. The methods for XSL transformation are also in "DataTransporter" namely "transformXmlStream" and "getXslStreamForXmlFile".
      The "importXmlStream" method (was "executeImport") is somewhat inconsistent and should be reviewed by the core developers. The two filters "ImportXmlRootFilter" and "MagnoliaV2Filter" for the XML stream are only applied when "keepVersionHistory" ist not true, otherwise the XML stream is completely unfilterred.
      The XSL transformation should happen after all filters are applied. This could be useful when bootstrapping and default values should be changed (passwords, subscribers, ...). It makes more sense to save a XSL file to version control, because it is easier to read and self-explanatory than an exported system view of the repository. Maybe a plugin mechanism for filters and transformations makes sense here.

      Checklists

        Acceptance criteria

        Attachments

          1. Bootstrapper.diff
            6 kB
          2. Bootstrapper.diff
            4 kB
          3. DataTransporter.diff
            15 kB
          4. DataTransporter.diff
            14 kB
          5. DataTransporter.java
            17 kB
          6. DataTransporter.java
            17 kB
          7. ImportPage.diff
            0.9 kB
          8. ModuleUtil.diff
            1 kB
          9. pom.diff
            0.5 kB

          Activity

            People

              pbaerfuss Philipp Bärfuss
              olli Oliver Lietz
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoD