Uploaded image for project: 'Backup'
  1. Backup
  2. MGNLBACKUP-112

Wrong repository config path is being resolved

XMLWordPrintable

    • Yes
    • Nucleus 8
    • 3

      Wrong repository config path is resolved when a manual backup is done (info.magnolia.module.backup.app.BackupPresenter.manualBackup())

      BackupOperationConfiguration configuration = backupOperationConfiguration()
                              .withBackupLocation(Paths.get(items.get(BackupView.FORM_VIEW_MANUAL_BACKUP).getItemProperty("backupPath").getValue().toString()))
                              .withRepositoryPath(Paths.get(properties.getProperty("magnolia.repositories.home"), "magnolia"))
                              .withConfigurationPath(Paths.get(properties.getProperty("magnolia.home"), properties.getProperty("magnolia.repositories.jackrabbit.config")))
                              .build();
      

      Here magnolia.home is used to compose the path in addition to magnolia.repositories.jackrabbit.config. magnolia.home can be configured in magnolia properties, so it might lead to errors locating this configuration file.

      I guess that it should be resolved as it is done in provider implementation for Apache JackRabbit JCR repository (info.magnolia.jackrabbit.ProviderImpl) where info.magnolia.cms.core.FileSystemHelper.getAbsoluteFileSystemPath(String) is used to compose the path, getting absolute filesystem path and adding application root if path is not absolute.

      Same for: info.magnolia.module.backup.commands.BackupCommand.executeAutomatedBackup(Context, String)

        Acceptance criteria

              ajuran AntonĂ­n Juran
              miruela Mercedes Iruela
              Nucleus
              Votes:
              3 Vote for this issue
              Watchers:
              9 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 0.5d
                  0.5d