Uploaded image for project: 'Cache Modules'
  1. Cache Modules
  2. MGNLCACHE-240

Optimise EhCache3Factory cache wrapping functionality

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None

    Description

      Problem

      EhCache3Factory wraps the EhCache instances into Magnolia adapter abstractions

      • accessed on every request
      • doesn't cache the wrappers
      • wrapper c-tor eventually instantiates couple of thousand mutexes (just an expensive operation)

      As it can be seen on the picture below - the problem is triggered by the SiteAwareCacheFilter implementation which dynamically resolves the page cache.
      (cc rkovarik - can you pls help understand how locking will even work in this situation - each request will seem to get its own blocking cache wrapper around EhCache and -> own set of locks... or not?)

      !https://s3-us-west-2.amazonaws.com/secure.notion-static.com/0084f036-d821-4307-a3d5-dfc7b9ae923e/Untitled.png(https://s3-us-west-2.amazonaws.com/secure.notion-static.com/0084f036-d821-4307-a3d5-dfc7b9ae923e/Untitled.png)
      The problematic

      Solution

      Cache the wrappers (it is after all only several of them and they typically don't change)

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                apchelintcev Aleksandr Pchelintcev
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 16m
                      16m