Uploaded image for project: 'Campaign Publisher'
  1. Campaign Publisher
  2. MGNLCAMPU-76

Dependency on personalization in not optional

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Neutral
    • None
    • 1.3.1

    Description

      We are seeing that we made use of "personalization-integration" however from Maven artifact dependency we don't have any coding reference to it, see below image:

      A draft investigation shown that we're using few of info.magnolia.personalization.action.IsNoVariantRule in some configuration points such as /modules/campaign-publisher/apps/campaigns/subApps/browser/actions/markReady/availability/rules/IsNoVariantRule

      Decouple these modules improve the "high cohesion and low coupling" of system.

      In module descriptor, personalization-integration is defined as a required dependency, not optional so this should be a logic bug from Magnolia development point of view, dependencies of bootstrapping only need to be listed as optional dependencies so that customer can remove the dependent modules in case they are not use it. Definition point in module descriptor here:

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                viet.nguyen Viet Nguyen
                AuthorX
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoD