Uploaded image for project: 'Magnolia DAM Module'
  1. Magnolia DAM Module
  2. MGNLDAM-136

Dam#getAssetsByQuery(String) should be enhanced

    XMLWordPrintable

Details

    • Bug
    • Resolution: Obsolete
    • Neutral
    • None
    • None
    • None
    • None

    Description

      Dam#getAssetByQuery(String) (introduced with MGNLDAM-70) has several defects:

      • it's exposing access to the PersistenceLayer to "everybody". As I learned this is just because of backwards compatibility. This should explicitly be mentioned in javadoc
      • it's using deprecated Query.SQL - again we should mention in javadoc why we use deprecated query language in new code (backwards compatibility)
      • it's not forwarding potential exceptions (again to be backwards compatible?)
      • it should use QueryUtil

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                dlipp Daniel Lipp
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD