Uploaded image for project: 'Magnolia DAM Module'
  1. Magnolia DAM Module
  2. MGNLDAM-49

Cleanup code introduced with MGNLDAM-19

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 1.0
    • 1.0
    • None
    • None

    Description

      As review took place only now, the original ticket MGNLDAM-19 couldn't be reopened. Hence a follow up ticket was created:
      AssetEditorUtils: drop it

      • don't implement imaging operation in dam - reuse from imaging module
        CropImageAction: adapt
      • never uses passed in constructor args LocationController & Node -> drop them
        AssetEditorSubAppViewImpl: adapt
      • view should not itself query JCR (AssetContentNodeStreamSource#getStream())
        -> should be implemented in a deeper layer (e.g. to be able to re-use e.g. from commands or Webservices)
      • use JcrConstants instead hardcoding "jcr:content" etc.
      • no e.printStackTrace() (#118)
      • session name "dam" is already defined in Dam#DAM_REPOSITORY -> use that constant rather then hardcoded same value (about 5 places in dam-app-assets)

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                apchelintcev Aleksandr Pchelintcev
                dlipp Daniel Lipp
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD